Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publication cache and querying subscriber #191

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Add publication cache and querying subscriber #191

merged 9 commits into from
Nov 20, 2023

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Nov 15, 2023 •
edited
Loading

Add publication cache and querying subscriber C bindings

For publication cache:

  • ze_declare_publication_cache
  • ze_undeclare_publication_cache
  • ze_publication_cache_check
  • ze_publication_cache_null
  • ze_publication_cache_options_default

For querying subscriber:

  • ze_declare_querying_subscriber
  • ze_undeclare_querying_subscriber
  • ze_querying_subscriber_check
  • ze_querying_subscriber_null
  • ze_querying_subscriber_options_default

Additionally provided bindings for required but unstable types:

  • zcu_locality_t
  • zcu_reply_keyexpr_t

Usage examples:

  • z_pub_cache.c
  • z_query_sub.c

Value of Z_CONFIG_ADD_TIMESTAMP_KEY changed to the actual one.

Mallets
Mallets reviewed Nov 16, 2023
View reviewed changes
src/commons.rs Outdated Show resolved Hide resolved
src/commons.rs Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose the following naming rule for everything that is unstable: zcu_xxx. Once the API is eventually stabilised, we can keep compatibility with existing code using unstable marking by adding a #define zc_xxx zcu_xxx.

@sashacmc sashacmc marked this pull request as ready for review November 17, 2023 09:48
@sashacmc sashacmc requested review from Mallets and p-avital November 17, 2023 09:49
p-avital
p-avital suggested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@p-avital p-avital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close, just a couple more changes and it's ready :)

src/publication_cache.rs Outdated Show resolved Hide resolved
include/zenoh_macros.h Show resolved Hide resolved
@Mallets Mallets merged commit 72f8a1c into eclipse-zenoh:master Nov 20, 2023
3 checks passed
@Mallets Mallets deleted the publication-cache branch November 20, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-avital p-avital p-avital approved these changes

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sashacmc @Mallets @p-avital